This project is archived and is in readonly mode.

#351 ✓wontfix
Christoph Pojer

Fx.Slide element margins

Reported by Christoph Pojer | September 3rd, 2010 @ 01:34 PM | in

Comments and changes to this ticket

  • Arian

    Arian September 20th, 2010 @ 05:29 PM

    • Milestone set to
    • Assigned user set to “Aaron Newton”
    • Milestone order changed from “197521” to “0”
  • Ryan Florence

    Ryan Florence September 22nd, 2010 @ 10:40 PM

    • Milestone order changed from “35” to “0”

    I posted on the original ticket:

    I'm not sure Fx.Slide should care. If you need to slide in an element that's got auto margins, wrap it in a parent element with auto margins. If we put in a check for auto margins, what other CSS will eventually need to be checked?

    The wrapper element inherits the margin of the element you're sliding, but it doesn't inherit the width, so margin: auto does nothing. A solution for this case would be to check for the margins of the element, if left or right are auto, then give the wrapper element a width equal to the width + border + padding of the element (otherwise it'll cut off any borders on the element).

    But again, not sure if it's worth it when you can just wrap the element and give the parent element the auto margin.

  • Aaron Newton

    Aaron Newton September 23rd, 2010 @ 04:23 PM

    • State changed from “new” to “wontfix”

    Fx.Slide is picky about CSS and I'm in agreement that we shouldn't spend the time to make it more robust. Using it at all requires you to know CSS. There's a CSS solution here, and I'm not so interested in adding more to Fx.Slide to work around not using it.

    That said, if there were a pull request that fixed this, I'd pull it.

    Marking as won't fix for now.

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

The MooTools Extensions

People watching this ticket