This project is archived and is in readonly mode.

#258 open
fakedarren

Various possible issues with Sortables

Reported by fakedarren | February 13th, 2010 @ 02:48 PM | in 1.4.0.1 (closed)

This is a single ticket condensing any issues still open from the -core ticket list.

https://mootools.lighthouseapp.com/projects/2706/tickets/249-1-2-so...
It seems related to setting the element style back to display: block as opposed to display: table-row (or whatever the original style was). Test case provided is no longer available.

https://mootools.lighthouseapp.com/projects/2706/tickets/233-table-...
Whilst I have not yet investigated why, I can confirm this is an issue in FF3.5

https://mootools.lighthouseapp.com/projects/2706/tickets/293-sortab...

https://mootools.lighthouseapp.com/projects/2706/tickets/697-ie-sor...

https://mootools.lighthouseapp.com/projects/2706/tickets/59-sortabl... (http://mootools.net/shell/8CPNa/)

Comments and changes to this ticket

  • Christiaan Hees

    Christiaan Hees February 19th, 2010 @ 01:24 PM

    • Assigned user changed from “Aaron Newton” to “fakedarren”

    I found a fix for 697:
    https://mootools.lighthouseapp.com/projects/2706/tickets/697-ie-sor...

    If you add these lines to the end of Sortables.initialize it will prevent the specific IE drag events to interfere:

    for(var i=0; i<this.elements.length; i++) {

    this.elements[i].ondragstart = function() { return false; };
    

    }

    It fixed the problem for me but I'm not a MooTools expert so I'm not sure if there's perhaps a better way to block the IE ondragstart event or that this will break something else.

  • Bart Garbiak

    Bart Garbiak March 1st, 2010 @ 01:32 PM

    Not sure if it should go here or should have it's own ticket: Firefox doesn't fire events of elements inside a sortable table. Test case here: http://mootools.net/shell/vA8eB/4/

  • infolock

    infolock March 16th, 2010 @ 01:43 AM

    • Tag changed from 1.2.4.5, sortables to 1, sortables

    @Christiaan Hees

    I tried your suggestion but it doesn't correct the issue. Another bit of information, this also happens when dealing with Flash objects in Firefox 3.5.8 and older. Bug 697 is really annoying. It's even more evident when you try layering sortables inside of sortables as well.

  • infolock

    infolock March 16th, 2010 @ 02:05 AM

    Update:: I just now read an article a guy wrote and this actually fixes the bug...

    You basically put this code BEFORE you initialize the Sortables object.

    Example:
    window.addEvent('domready', function() {
    document.ondragstart = function() { return false; }; var sortableLists = new Sortables($$('.sortables'), { / blah blah blah... / }); });

    quote: "It turns out that Internet Explorer has a custom event called ondragstart applied to the document element. In order to make Internet Explorer play nice, that event must be overwritten to basically do nothing. This prevents the default IE drag behavior and makes Sortables (with images) work like a champ."

    Source: http://somethingcliche.com/2009/12/18/ie-hack-for-mootools-sortable...

    This not only fixes the issues with Images, but it also fixes the cases where sortables are layered inside of other sortables.

  • hectic

    hectic May 13th, 2010 @ 03:11 PM

    • Assigned user cleared.

    Hi Guys,

    Sortables are very slow in IE7,IE8 with large amount of sortable items but perfect in Firefox and Google Chrome.

    Steps I took:
    - Using mootools 1.2.4 I applied document.ondragstart = function() { return false; }; fix to my code mentioned by infolock above but this did not make a difference

    To Reproduce
    - downloaded demo sortables demo at http://demos.mootools.net/Sortables - ran demo with mootools 1.2.4 - altered demo.js code to generate >400 sortable items. Again works really well in Firefox and Google Chrome but not in IE7,IE8 even with fix above added. Very slow.

    Any ideas?

  • JacobThornton

    JacobThornton September 18th, 2010 @ 06:07 PM

    • Milestone order changed from “0” to “0”

    Currently sortables processes all 400 objects, so it's going to be a bit slower in ie. At my last company we worked a lot with email and found this to be the case when users infinitely scrolled their inboxes.

    I'd suggest trying a delegated solution (which soon will hopefully be made available as an option in Sortables) or you could extend the current sortables to use it.

  • Tim Wienk

    Tim Wienk November 12th, 2010 @ 12:09 AM

    • State changed from “open” to “new”
    • Milestone changed from 1.2.5.2 to 1.3.1.1
    • Tag changed from 1, sortables to sortables
    • Milestone order changed from “19” to “0”

    These tickets should be reverified, maybe for the separate issues a new ticket so we can handle this per issue?

  • Arian

    Arian December 23rd, 2010 @ 11:54 PM

    • Milestone order changed from “1” to “0”

    1: invalid

    2: invalid

    3: invalid, works fine: http://jsfiddle.net/arian/kjBmL/1/

    4: Sortables and Images in IE was already fixed

    5: Still valid: http://jsfiddle.net/arian/SMn3C/

  • JacobThornton

    JacobThornton December 30th, 2010 @ 07:43 AM

    • Assigned user set to “JacobThornton”
  • JacobThornton

    JacobThornton December 30th, 2010 @ 07:45 AM

    • State changed from “new” to “open”
  • Slava
  • Arian

    Arian February 25th, 2011 @ 08:15 PM

    • Milestone changed from 1.3.1.1 to 1.4.0.1
    • Milestone order changed from “2” to “0”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

The MooTools Extensions

Tags

Referenced by

Pages