This project is archived and is in readonly mode.

#308 ✓invalid
Constantine Zykov

Form.Validator.Russian.js contains broken data for win-1251 charset.

Reported by Constantine Zykov | May 8th, 2010 @ 05:36 PM | in 1.3.0.1 rc1

Here is demo (errors are showed with invalid characters):
- http://www.falsecode.ru/blog/demos/mootools/form-validation-win1251...

In attach file without broken locale 'ru-RU'.

Comments and changes to this ticket

  • Arian

    Arian September 25th, 2010 @ 11:52 AM

    • Milestone set to 1.3.0.1 rc1
    • Assigned user set to “Tim Wienk”
    • Milestone order changed from “0” to “0”

    We've cleaned up the localization in 1.3 a lot. Could you confirm if this ticket is still valid?

  • Tim Wienk

    Tim Wienk September 26th, 2010 @ 03:11 PM

    • State changed from “new” to “open”

    Everything works fine for me on a utf-8 page. Maybe some collision between the cp-1251 the website uses, and utf-8 the MooTools files use?

    When I open the 1.2 source, 1.3 source and the fix, they show no differences to me, all valid utf-8.

    I'll wait with marking this as invalid until there's a reaction from insanio, but I don't see any problems.

  • Tim Wienk

    Tim Wienk September 26th, 2010 @ 08:55 PM

    • State changed from “open” to “invalid”

    I only just read the title again. Title suggests that insanio expected the contents to be Windows cp-1251 while they are utf-8. That's why it's called ru-RU-unicode.

    In 1.3 this will be just ru-RU, and for backward compatibility using ru-RU-unicode will give you the same translations.

  • Constantine Zykov

    Constantine Zykov September 29th, 2010 @ 07:17 AM

    There are 2 problems.

    1. There are 2 locales in 2 different code pages (win-1251 and utf-8). While file was saved in utf-8, so win-1251 is broken (I will fix example so it will show the problem, now you see English locale error messages).

    2. If you creating site in Russian, you have to choose, what code page it will use: win-1251 or utf-8. So 2 code pages in 1 file is superfluous. It is better to divide them into 2 files. For example, Form.Validator.Russian and Form.Validator.Russian.utf8. So, we will fix win-1251 code page, give user choice between the code pages to save loading time of More.

  • Constantine Zykov

    Constantine Zykov October 4th, 2010 @ 03:49 AM

    I fixed file with example: http://www.falsecode.ru/blog/demos/mootools/form-validation-win1251.... You can check code page of the example - windows-1251. More locale is ru-RU: MooTools.lang.setLanguage('ru-RU'); By idea it have to work, but validation messages are in abra-cadabra language.

    Because of broken windows-1251 locale. The reasons I tried to explain above.

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

The MooTools Extensions

People watching this ticket

Attachments

Pages