This project is archived and is in readonly mode.

#483 open
JacobThornton

get spec passing... 100%

Reported by JacobThornton | January 6th, 2011 @ 12:49 AM | in 1.4.0.1 (closed)

In firefox, chain.waits test "should wait some milliseconds between firing the functions" doesn't pass always. This test should be modified to work, or removed.

In san francisco, date format fails:

should format a Date instance as a string
Expected '1997-11-20T09:02:03.000Z' to equal '1997-11-20T00:02:03.000Z'.

Comments and changes to this ticket

  • JacobThornton

    JacobThornton January 6th, 2011 @ 12:51 AM

    • State changed from “new” to “open”

    also, it would be nice to clean up also those height 1px elements and the bottom of the spec...

  • Arian

    Arian January 6th, 2011 @ 12:54 AM

    I believe the time of the waits function (the jasmine waits) should be increased. I think that would fix the Chain.Waits.

    The date spec fails because one date is hardcoded... so someone at the other side of the ocean should have a look at it, because they pass here obviously.

    I believe most of the 1px elements are from the Element.Forms specs. They should be destroyed after the specs ran.

  • Arian

    Arian January 6th, 2011 @ 01:00 AM

    I also get, with Firefox 3.6, in the Form.Validators > Validators > validate-one-required:

    TypeError: p is null in http://localhost/mootools/mootools-more/Source/Forms/Form.Validator.js (line 480)
    

    Some Assets specs don't fire the error event as well for Asset.image

  • JacobThornton

    JacobThornton January 6th, 2011 @ 04:48 AM

    I also get this in ie:

    URI use where string is expected
    runRequest self should work with an URI object
    TypeError: Access is denied.

  • Arian

    Arian January 7th, 2011 @ 11:28 PM

    • Milestone order changed from “45” to “0”

    Everything passes for me now in Chrome, Opera, IE8, Firefox and Safari.

    IE7 (IE8-compat-mode) and IE6 (ie-tester) have some troubles though:

    • Element.Pin -> Pin -> should not change position of the element on the page: div.unpin() undefined property/method not supported

    • HtmlTable -> HtmlTable:push -> should push an array with options and properties: Expected { text : 'grapes', rowspan : 1, valign : null } to equal { text : 'grapes', rowspan : '2', valign : 'top' }.

    Only IE7

    • Some Request.JSONP error (looks like the Element.Pin error)
  • Arian
  • Arian

    Arian January 13th, 2011 @ 08:36 PM

    HtmlTable Sortable Test was a trailing comma and was fixed.

    Element.Pin error was fixed: https://github.com/arian/mootools-more/commit/6dc4b11c610

    HtmlTable.push seems not really a problem in HtmlTable in IE7: http://jsfiddle.net/4RyM7/5/ so I don't know if this is a problem for us...

  • Arian

    Arian January 13th, 2011 @ 08:45 PM

    When running only the 'base' specs in IE, some getTimezone methods return UTC instead of GTM. That is a IE issue though and in some places in the specs it is already avoided.

  • Arian

    Arian January 26th, 2011 @ 12:35 AM

    Running Specs in Node.js results in one failure:

    Spec Events.Pseudos
      it should implement Event.Psuedos in already existing classes defined in core
      Error: Expected spy complete to have been called.
    
  • Arian

    Arian February 25th, 2011 @ 08:15 PM

    • Milestone changed from 1.3.1.1 to 1.4.0.1
    • Milestone order changed from “46” to “0”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

The MooTools Extensions

People watching this ticket

Tags

Pages