This project is archived and is in readonly mode.

#521 ✓wontfix
Fred Choquet

position issue in 1.2.5.1

Reported by Fred Choquet | February 24th, 2011 @ 02:11 PM

Element.position, code changed in 1.2.5.1

var relScroll = rel.getScroll();
if (options.ignoreScroll) {

pos.top -= relScroll.y;
pos.left -= relScroll.x;

} else {

pos.top += relScroll.y;
pos.left += relScroll.x;

}

instead of

if (options.ignoreScroll) {

var relScroll = rel.getScroll();
pos.top-= relScroll.y;
pos.left-= relScroll.x;

}

It changes the behaviour when trying to display a screen centered div by calling position() without argument: The div gets too low depending of the scroll level.

In version 1.3.1.1 the upgrade is canceled. It's back to the previous code:

if (options.ignoreScroll) {

var relScroll = rel.getScroll();
pos.top-= relScroll.y;
pos.left-= relScroll.x;

}

I think it worth a 1.2.5 patch or an explanation on how to manage compatibility between 1.2.4 and 1.2.5

Comments and changes to this ticket

  • Arian

    Arian February 25th, 2011 @ 09:24 PM

    • Assigned user set to “Aaron Newton”

    We don't plan to release another 1.2 version. I wouldn't know why this was changed. However maybe Aaron wants to take a look?

  • fakedarren

    fakedarren July 16th, 2011 @ 04:14 PM

    • State changed from “new” to “wontfix”

    Hi Fred

    I'm afraid we will not be releasing another 1.2.x version so I am going to mark this as wontfix.

    Sorry
    Darren

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

The MooTools Extensions

Pages