This project is archived and is in readonly mode.

#1101 ✓resolved
mattcoz

In IE7, getAttributeNode is not reliable for input type attribute selectors

Reported by mattcoz | November 26th, 2010 @ 08:57 PM | in 1.3.1 (closed)

On input types that IE7 does not recognize(number, date, etc), getAttributeNode('type').nodeValue will return "text" instead of the actual value. This causes Slick to fail to find the input when using the type attribute selector.

http://jsfiddle.net/mattcoz/32Wzw/

Instead we should use getAttribute which does return the actual value.

https://github.com/mattcoz/slick/commit/35da987782e81c254bdd369c8ed...

A possible related question. In the source it says:

// FIXME: check if getAttribute() will get input elements on a form on this browser
// getAttribute is faster than getAttributeNode().nodeValue

What exactly does this mean?

Comments and changes to this ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Shared Ticket Bins

Pages