This project is archived and is in readonly mode.

#438 ✓wontfix
Tim Harwood

getCompatElement returning doc.html for webkit

Reported by Tim Harwood | October 22nd, 2008 @ 09:25 AM | in 1.3.0 rc2 (closed)

Hey folks,

Working on a site using MVC (unfortunately in a few too many bits to upload just yet to let you view the problem, though should be there in a couple of days) where I have a list of views of 'projects' which when their model fires a selected event, resize themselves and in turn fire a resize event which makes the containing page scroll to them.

This works fine in everything except safari & chrome (webkit).

I did a little digging around and came up with this comment on Window.size.js from your v1 forum: suggesting essentially that webkit needs to use document.body to get scroll sizes.

Followed this through to to the getCompatElement function, which returns doc.html to webkit, because it passes (doc.compatMode == 'CSS1Compat').

I've added a (!Browser.Engine.webkit) clause to my version and now webkit scrolls fine as well (and so far it hasn't bust anything else...)

Unfortunately because the function is private I can't overwrite it, so I've had to make the edit in my actual core file, so I figured I'd flag it and see if it's a low impact alt that can make an imminent release.

Cheers T

Comments and changes to this ticket

  • fakedarren

    fakedarren February 8th, 2010 @ 07:34 PM

    • Milestone changed from 2.0 to 1.3.0 rc2
    • State changed from “new” to “hold”
    • Assigned user changed from “Valerio” to “fakedarren”


    Is this still an issue? Sorry it's taken so long to get back to you. But I don't properly understand the original bug - can you clarify?

  • fakedarren

    fakedarren February 15th, 2010 @ 10:39 PM

    • State changed from “hold” to “wontfix”

    Cannot recreate a test case and don't fully understand the original issue; considering it's a webkit issue I have to assume this is browser-specific and has been resolved.

    If OP can provide a test case we'll reopen.

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Shared Ticket Bins

People watching this ticket