This project is archived and is in readonly mode.

#665 ✓invalid
SchizoDuckie

Bug in slider:End not reachable by dragging

Reported by SchizoDuckie | May 9th, 2009 @ 05:56 PM

  • This is somewhat a duplicate of bug #221, but since that's put on hold and it's still here in 1.2.2 i'll post it here.*

There's a bug in the slider that prevents you from dragging to the max value. However, when using wheel:true you can get to the end.

I downloaded the demo from demos.mootools.net and adjusted it.

Any suggestions?

Comments and changes to this ticket

  • SchizoDuckie

    SchizoDuckie May 9th, 2009 @ 07:44 PM

    • Tag changed from 1.2.2, regression, slider to 1.2.2, regression, slider

    Just fixed it:

    
    
    toStep: function(position){
    	var step = (position + this.options.offset) * this.stepSize / this.full * this.steps;
    	return this.options.steps ? Math.ceil(step -= step % this.stepSize) : step;
    },
    
    

    Changed math.round to math.ceil.

  • SchizoDuckie

    SchizoDuckie May 9th, 2009 @ 07:57 PM

    Lol, this fixes it for the demo i edited, but apparently not for my current testcase... Work in progres..

  • SchizoDuckie

    SchizoDuckie May 9th, 2009 @ 09:09 PM

    The toStep() patch was half the work. This is the rest:

    in initialize, change the snap option to:

    
    	if (this.options.snap){
    		dragOptions.grid = this.stepWidth;
    		dragOptions.limit[this.axis][1] = this.full;
    	}
    

    This will ensure that we don't snap on a position smaller than needed due to rounding.

    
    draggedKnob: function(){
    	var dir = this.range < 0 ? -1 : 1;
    	var position = this.drag.value.now[this.axis];
    	position = position.limit(-this.options.offset, this.full -this.options.offset);
    	this.step = Math.ceil(this.min + dir * this.toStep(position));
    	this.checkStep();
    },
    
    
  • fakedarren

    fakedarren February 8th, 2010 @ 05:27 PM

    • State changed from “new” to “open”
    • Assigned user set to “fakedarren”
    • Milestone cleared.

    SchizoDuckie! Long time no see in IRC.....

    I've marked this as open, I need to get a test case together. If you can make a mooshell of the problem that would be grand.

  • fakedarren

    fakedarren February 13th, 2010 @ 02:09 PM

    • State changed from “open” to “invalid”

    Hi SchizoDuckie

    If you check the documentation you can see that Aaron has written a short piece on how CSS can cause this. Unfortunately your example requires an external CSS file which I do not have. Therefore, I have to assume that Aaron's notes in the documentation would resolve this issue for you.

    As mentioned if you can provide a mooshell that proves this not to be the case, please reply and we will re-open the ticket.

    Cheers
    Darren

  • Christoph Pojer

    Christoph Pojer September 3rd, 2010 @ 01:12 PM

    • Tag changed from 1.2.2, regression, slider to 1.2.2, slider
    • Milestone order changed from “0” to “0”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Shared Ticket Bins

Attachments

Tags

Pages