#944 Better way for extending the Request Class - mootools.core

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#944 ✓invalid

Better way for extending the Request Class

Reported by schelmo | July 12th, 2010 @ 03:26 PM | in 2.0 (closed)

It is very hard to override the send method of the Request Class. it would be better to split it in several functions.

i made up a fiddle as example http://www.jsfiddle.net/cNhTd/

and added 2 new functions: processData() and sendRequest()

What do you think ?

Comments and changes to this ticket

Sebastian Markbåge July 12th, 2010 @ 04:25 PM
- Milestone set to “1.3.1”
- Assigned user set to “Sebastian Markbåge”
- State changed from “new” to “open”
- Milestone order changed from “779” to “0”
I agree. Maybe URL processing should be extracted too. It needs to include a step that can indicate whether or not it's a cross-domain request. Like I did in this branch to support cross-domain requests:

http://github.com/calyptus/mootools-core/blob/request/Source/Reques...

It allow you to extend it with IE8's XDomainRequest.

http://gist.github.com/304197
Arian July 12th, 2010 @ 06:10 PM
++

Send method is too big and tries too much.
If its splitted up into more methods, its easier to extend Request and reuse certain methods.
Christoph Pojer September 5th, 2010 @ 01:08 PM
- Milestone changed from “1.3.1” to “1.3.0 rc2”
Christoph Pojer September 7th, 2010 @ 02:59 AM
- Assigned user changed from “Sebastian Markbåge” to “Christoph Pojer”
This is my proposal: http://github.com/cpojer/mootools-core/compare/1.3-request

I have added some remarks on the bad parts of this implementations. I am open to any suggestions :)
Christoph Pojer September 9th, 2010 @ 12:00 AM
- Milestone changed from “1.3.0 rc2” to “1.3.1”
- Milestone order changed from “1” to “0”
Christoph Pojer September 21st, 2010 @ 04:26 PM
- Assigned user changed from “Christoph Pojer” to “Valerio”
Christoph Pojer October 19th, 2010 @ 09:29 AM
- Milestone changed from “1.3.1” to “2.0”
- Milestone order changed from “3” to “0”
You flagged this item as spam.
André Cruz March 20th, 2011 @ 12:15 PM
Agree, also shouldn't the XDomainRequest be supported in the next releases?
ibolmo January 19th, 2012 @ 09:16 AM
- State changed from “open” to “invalid”
Moved to Github Issues: https://github.com/mootools/mootools-core/issues/2228

Please use Github Issues, since Lighthouse has been deprecated.